Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump traitlets from 5.0.2 to 5.0.3 #1713

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Bump traitlets from 5.0.2 to 5.0.3 #1713

merged 1 commit into from
Sep 4, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 4, 2020 •
edited
Loading

Bumps traitlets from 5.0.2 to 5.0.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Sep 4, 2020
@dependabot-preview
Bump traitlets from 5.0.2 to 5.0.3
1c1be91 
Bumps [traitlets](https://github.com/ipython/traitlets) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/ipython/traitlets/releases)
- [Commits](ipython/traitlets@5.0.2...5.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #1713 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files         115      115           
  Lines       14445    14445           
  Branches     1106     1106           
=======================================
  Hits        14389    14389           
  Misses         41       41           
  Partials       15       15

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@pquentin
Copy link
Member

pquentin commented Sep 4, 2020

test_pipes failed like this:

2020-09-04T04:45:16.8135030Z 
2020-09-04T04:45:16.8137380Z     async def test_pipes():
2020-09-04T04:45:16.8137690Z         async with await open_process(
2020-09-04T04:45:16.8141990Z             COPY_STDIN_TO_STDOUT_AND_BACKWARD_TO_STDERR,
2020-09-04T04:45:16.8143940Z             stdin=subprocess.PIPE,
2020-09-04T04:45:16.8144210Z             stdout=subprocess.PIPE,
2020-09-04T04:45:16.8144450Z             stderr=subprocess.PIPE,
2020-09-04T04:45:16.8144700Z         ) as proc:
2020-09-04T04:45:16.8144850Z             msg = b"the quick brown fox jumps over the lazy dog"
2020-09-04T04:45:16.8144960Z     
2020-09-04T04:45:16.8145080Z             async def feed_input():
2020-09-04T04:45:16.8145210Z                 await proc.stdin.send_all(msg)
2020-09-04T04:45:16.8145520Z                 await proc.stdin.aclose()
2020-09-04T04:45:16.8154010Z     
2020-09-04T04:45:16.8154220Z             async def check_output(stream, expected):
2020-09-04T04:45:16.8154370Z                 seen = bytearray()
2020-09-04T04:45:16.8154540Z                 async for chunk in stream:
2020-09-04T04:45:16.8154670Z                     seen += chunk
2020-09-04T04:45:16.8154790Z                 assert seen == expected
2020-09-04T04:45:16.8154910Z     
2020-09-04T04:45:16.8155040Z             async with _core.open_nursery() as nursery:
2020-09-04T04:45:16.8155930Z                 # fail quickly if something is broken
2020-09-04T04:45:16.8156280Z                 nursery.cancel_scope.deadline = _core.current_time() + 3.0
2020-09-04T04:45:16.8156640Z                 nursery.start_soon(feed_input)
2020-09-04T04:45:16.8156820Z                 nursery.start_soon(check_output, proc.stdout, msg)
2020-09-04T04:45:16.8158350Z                 nursery.start_soon(check_output, proc.stderr, msg[::-1])
2020-09-04T04:45:16.8158670Z     
2020-09-04T04:45:16.8158870Z >           assert not nursery.cancel_scope.cancelled_caught
2020-09-04T04:45:16.8159070Z E           assert not True
2020-09-04T04:45:16.8159280Z E            +  where True = <trio.CancelScope at 0x10d376880, exited, cancelled>.cancelled_caught
2020-09-04T04:45:16.8159520Z E            +    where <trio.CancelScope at 0x10d376880, exited, cancelled> = <trio.Nursery object at 0x10a8c4b80>.cancel_scope
2020-09-04T04:45:16.8159660Z 
2020-09-04T04:45:16.8160480Z ../../../../hostedtoolcache/Python/3.8.5/x64/lib/python3.8/site-packages/trio/tests/test_subprocess.py:143: AssertionError

Closing/reopening

@pquentin pquentin closed this Sep 4, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@pquentin pquentin reopened this Sep 4, 2020
@pquentin pquentin mentioned this pull request Sep 4, 2020
Open
@dependabot-preview dependabot-preview bot merged commit 4e4f219 into master Sep 4, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/pip/traitlets-5.0.3 branch September 4, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pquentin